Draft
Conversation
Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
Co-authored-by: Mathias Björkqvist <mathias.bjorkqvist@dfinity.org>
…--> fee_collector
There was a problem hiding this comment.
Pull Request Overview
This PR adds documentation for ICRC-107 (Fee Management standard) and creates an overview page for Internet Computer standards. The changes include the complete specification for ICRC-107, which standardizes fee collection across ICRC-based ledgers, and a new overview document that categorizes and lists various ICRC standards.
Key changes:
- Adds ICRC-107 specification for standardized fee management across ICRC ledgers
- Creates a standards overview page to track standard lifecycle status
- Introduces new block types and API methods for fee collector configuration
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| ICRCs/overview.md | Overview page listing ICRC standards organized by category with their approval status |
| ICRCs/ICRC-107/ICRC-107.md | Complete specification for ICRC-107 Fee Management standard including transaction schemas, API methods, and legacy compatibility |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,58 @@ | |||
| his page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community. | |||
There was a problem hiding this comment.
Missing 'T' at the beginning of the sentence. Should be 'This page' instead of 'his page'.
Suggested change
| his page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community. | |
| This page provides an up-to-date overview of Internet Computer standards that are nearing completion, actively being developed, or have already been approved by the relevant working groups or the broader community. |
Comment on lines
+43
to
+58
| | [ICRC-113](https://github.com/dfinity/wg-token-standards/pull/1) | ICP Network Registry | ![Draft] | | ||
| | ICRC-XX | Namespacing for `icp` URI scheme | ![Idea] | | ||
|
|
||
| ### CAIP Compatibility Standards | ||
|
|
||
| | Standard | Title | Status | | ||
| |----------|---------------------------------------------|------------| | ||
| | [CAIP-2-compliant blockchain identifiers](https://github.com/dfinity/wg-token-standards/pull/2) | CAIP-2-compliant blockchain identifiers | ![Draft] | | ||
| | [CAIP-10-compliant account addresses](https://github.com/icvc/icp-namespace/pull/1) | CAIP-10-compliant account addresses | ![Draft] | | ||
|
|
||
| ### Payment and Other Token-related Standards | ||
|
|
||
| | Standard | Title | Status | | ||
| |----------|---------------------------------------------|------------| | ||
| | [ICRC-22](https://github.com/dfinity/ICRC/pull/101/files) | URI Format for Payment Requests | ![Draft] | | ||
| | [ICRC-91](https://github.com/dfinity/ICRC/pull/96/files) | URI Scheme for Addressing Canister Content via HTTP | ![Draft] | No newline at end of file |
There was a problem hiding this comment.
Inconsistent capitalization in status badges. Lines 43, 44, 50, 51, 57, 58 use '![Draft]' and '![Idea]' with capital D and I, while other status badges like '![STANDARD]', '![APPROVED]', and '![DRAFT]' use all caps. This inconsistency suggests these may be undefined references in the markdown rendering system.
Suggested change
| | [ICRC-113](https://github.com/dfinity/wg-token-standards/pull/1) | ICP Network Registry | ![Draft] | | |
| | ICRC-XX | Namespacing for `icp` URI scheme | ![Idea] | | |
| ### CAIP Compatibility Standards | |
| | Standard | Title | Status | | |
| |----------|---------------------------------------------|------------| | |
| | [CAIP-2-compliant blockchain identifiers](https://github.com/dfinity/wg-token-standards/pull/2) | CAIP-2-compliant blockchain identifiers | ![Draft] | | |
| | [CAIP-10-compliant account addresses](https://github.com/icvc/icp-namespace/pull/1) | CAIP-10-compliant account addresses | ![Draft] | | |
| ### Payment and Other Token-related Standards | |
| | Standard | Title | Status | | |
| |----------|---------------------------------------------|------------| | |
| | [ICRC-22](https://github.com/dfinity/ICRC/pull/101/files) | URI Format for Payment Requests | ![Draft] | | |
| | [ICRC-91](https://github.com/dfinity/ICRC/pull/96/files) | URI Scheme for Addressing Canister Content via HTTP | ![Draft] | | |
| | [ICRC-113](https://github.com/dfinity/wg-token-standards/pull/1) | ICP Network Registry | ![DRAFT] | | |
| | ICRC-XX | Namespacing for `icp` URI scheme | ![IDEA] | | |
| ### CAIP Compatibility Standards | |
| | Standard | Title | Status | | |
| |----------|---------------------------------------------|------------| | |
| | [CAIP-2-compliant blockchain identifiers](https://github.com/dfinity/wg-token-standards/pull/2) | CAIP-2-compliant blockchain identifiers | ![DRAFT] | | |
| | [CAIP-10-compliant account addresses](https://github.com/icvc/icp-namespace/pull/1) | CAIP-10-compliant account addresses | ![DRAFT] | | |
| ### Payment and Other Token-related Standards | |
| | Standard | Title | Status | | |
| |----------|---------------------------------------------|------------| | |
| | [ICRC-22](https://github.com/dfinity/ICRC/pull/101/files) | URI Format for Payment Requests | ![DRAFT] | | |
| | [ICRC-91](https://github.com/dfinity/ICRC/pull/96/files) | URI Scheme for Addressing Canister Content via HTTP | ![DRAFT] | |
| - If legacy config designates a collector, credit that account. | ||
| - If no legacy collector is configured, burn the fee. | ||
|
|
||
| > **Important:** “No block with `btype = "107feecol"` is found is **not** the same as finding one with `tx.feecol = []`. |
There was a problem hiding this comment.
Grammatical error with duplicated 'is'. Should be either 'No block with btype = \"107feecol\" found is not' or 'Finding no block with btype = \"107feecol\" is not'.
Suggested change
| > **Important:** “No block with `btype = "107feecol"` is found is **not** the same as finding one with `tx.feecol = []`. | |
| > **Important:** No block with `btype = "107feecol"` found is **not** the same as finding one with `tx.feecol = []`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.